[CTL] Add variadic functions #1123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KFilipek
force-pushed
the
task-ctl_variadic
branch
2 times, most recently
from
d5b2769 to
46b49d9
Compare
PatKamin
reviewed
Feb 24, 2025
KFilipek
force-pushed
the
task-ctl_variadic
branch
from
46b49d9 to
512ee27
Compare
PatKamin
reviewed
Feb 26, 2025
KFilipek
force-pushed
the
task-ctl_variadic
branch
from
512ee27 to
f60e823
Compare
PatKamin
approved these changes
Feb 26, 2025
KFilipek
force-pushed
the
task-ctl_variadic
branch
from
f60e823 to
bab8940
Compare
bratpiorka
reviewed
Feb 26, 2025
src/libumf.def
Outdated
| @@ -119,6 +119,9 @@ EXPORTS | |||
| umfScalablePoolParamsSetKeepAllMemory | |||
| ; Added in UMF_0.11 | |||
| umfCUDAMemoryProviderParamsSetAllocFlags | |||
| umfCtlExec | |||
There was a problem hiding this comment.
please move CTL functions to 0.12 namespace
There was a problem hiding this comment.
also, bump OPS structure version to 0.12
There was a problem hiding this comment.
I've updated structures for pool and provider, and also def+map files.
KFilipek
force-pushed
the
task-ctl_variadic
branch
from
bab8940 to
d425443
Compare
Since this commit all the CTL API functions (umfCtlSet/Get/Exec) will be defined as a variadic functions to provide more elastic approach in future development.
KFilipek
force-pushed
the
task-ctl_variadic
branch
from
d425443 to
c1739da
Compare
lplewa
requested changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CTL] Add variadic functions
Description
Since this PR all the CTL API functions (umfCtlSet/Get/Exec)
will be defined as a variadic functions to provide more elastic
approach in future development.
Checklist
Depends on #1073
Resolves #1085